-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swarm-derive: Specify NetworkBehaviour
by full path
#2932
swarm-derive: Specify NetworkBehaviour
by full path
#2932
Conversation
@folex can you grant me permissions to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing the patch. I will make sure it makes it into v0.49.0
(#2931).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this patch.
LGTM modulo the changelog and @mxinden's suggestion!
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
I don't see how to do that in GitHub without actually adding you to the fluencelabs org -_- |
Co-authored-by: Max Inden <mail@max-inden.de>
There is a checkbox next to the people that are subscribed to the PR that will allow us to push to this branch only. |
NetworkBehaviour
by full path
Seems like that doesn't work with organisations, only with personal forks. 🤔 |
Description
Specify
NetworkBehaviour
as::libp2p::swarm::NetworkBehaviour
in derive.Links to any relevant issues
#2921
Open Questions
Change checklist