Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libp2p-tls: Allow to specify remote peer ID we intend to connect to #2947

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Sep 27, 2022

Description

The public host key allows the peer to calculate the peer ID of the peer it is connecting to. Clients MUST verify that the peer ID derived from the certificate matches the peer ID they intended to connect to, and MUST abort the connection if there is a mismatch.

Links to any relevant issues

#2946

This does not affect Upgrades but can be useful for QUIC.

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@kpp
Copy link
Contributor Author

kpp commented Sep 28, 2022

ping @thomaseizinger

@thomaseizinger
Copy link
Contributor

Cool, thanks @kpp and sorry for the delay!

@thomaseizinger thomaseizinger merged commit 79a464a into libp2p:libp2p-tls Sep 28, 2022
@kpp kpp deleted the tls_verify_peer_id branch September 29, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants