Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/mdns: Update to if-watch v2.0.0 #2978

Merged
merged 8 commits into from
Oct 5, 2022

Conversation

umgefahren
Copy link
Contributor

@umgefahren umgefahren commented Oct 4, 2022

Description

As suggested I updated the version of if-watch. This should reduce compile time, since the versions used in tcp and mdns are now aligned.

Links to any relevant issues

Resolves #2895.

Change checklist

  • I have performed a self-review of my own code
  • A changelog entry has been made in the appropriate crates

Copy link
Contributor Author

@umgefahren umgefahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@umgefahren
Copy link
Contributor Author

Since @mxinden authored if-watch, it would be great if he would take a look :)

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM!

Thanks!

protocols/mdns/src/behaviour.rs Outdated Show resolved Hide resolved
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @mxinden authored if-watch, it would be great if he would take a look :)

Actually credit does not go to me but to @dvc94ch. I am only maintaining it.

This looks good to me. One small suggestion.

protocols/mdns/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mxinden mxinden merged commit 87ab49e into libp2p:master Oct 5, 2022
@umgefahren umgefahren deleted the update-if-watch-mdns branch October 5, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to if-watch v2.0.0 in mdns
3 participants