Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm: Split the ConnectionHandler::inject_listen_upgrade_error into two methods #3098

Closed

Conversation

maschad
Copy link
Member

@maschad maschad commented Nov 9, 2022

Description

I am adding a new method i.e. inject_listen_negotiation_error to handle errors which occur during the protocol negotiation step. i.e when the UpgradeInfo::protocol_info method is called in order to determine which protocols are supported by the trait implementation.

Links to any relevant issues

#2894

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Commit message body

@thomaseizinger
Copy link
Contributor

We might want to hold off on this until #3085 is merged.

@maschad
Copy link
Member Author

maschad commented Nov 12, 2022

Good call @thomaseizinger

@jxs
Copy link
Member

jxs commented Dec 13, 2022

#3085 has landed.

@maschad
Copy link
Member Author

maschad commented Dec 13, 2022

Thanks for the update @jxs I am bit preoccupied with some issues on js-libp2p so I haven't had a chance to work on this. Perhaps it may be best to assign this to someone else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants