Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swarm): Make executors pub and add convenience constructors for SwarmBuilder #3155

Merged
merged 3 commits into from
Nov 23, 2022
Merged

fix(swarm): Make executors pub and add convenience constructors for SwarmBuilder #3155

merged 3 commits into from
Nov 23, 2022

Conversation

umgefahren
Copy link
Contributor

Description

Addresses issues raised here: #3097 (comment)

Links to any relevant issues

Follows from #3097.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@umgefahren umgefahren mentioned this pull request Nov 22, 2022
Merged
7 tasks
@dignifiedquire
Copy link
Member

thank you!

@thomaseizinger
Copy link
Contributor

I'd like to merge libp2p/test-plans#77 first so we have a green CI.

@mxinden mxinden added this to the v0.50.0 milestone Nov 22, 2022
mxinden
mxinden approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, very much appreciate the help @umgefahren!

swarm/src/executor.rs
@@ -1,3 +1,4 @@
//! Provides executors for spawning background tasks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight on my end on #3097: Would you mind adding a license header here? See other files in the repository.

@mergify mergify bot merged commit 76dba17 into libp2p:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
v0.50.0
Development

Successfully merging this pull request may close these issues.
4 participants
@umgefahren @dignifiedquire @thomaseizinger @mxinden