-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(swarm): remove deprecated inject calls #3264
Changes from all commits
c0bf884
29f4882
61d3535
500283a
d29a8c9
354257e
ab14438
0831cba
264b27f
b9afb31
2325c6b
49162b4
a0af32b
e2e8d93
a6c052d
6232ff6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,19 @@ | ||
# 0.31.0 | ||
# 0.32.0 [unreleased] | ||
|
||
- Replace `NetworkBehaviour` Derive macro deprecated `inject_*` method implementations | ||
with the new `on_swarm_event` and `on_connection_handler_event`. | ||
Comment on lines
3
to
4
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This entry was previously mistakenly in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah exactly, thanks for referring this Max. |
||
See [PR 3011]. | ||
See [PR 3011] and [PR 3264]. | ||
|
||
[PR 3011]: https://github.com/libp2p/rust-libp2p/pull/3011 | ||
[PR 3264]: https://github.com/libp2p/rust-libp2p/pull/3264 | ||
|
||
# 0.31.0 | ||
|
||
- Add `prelude` configuration option. | ||
The derive-macro generates code that needs to refer to various symbols. See [PR 3055]. | ||
|
||
- Update `rust-version` to reflect the actual MSRV: 1.60.0. See [PR 3090]. | ||
|
||
[PR 3011]: https://github.com/libp2p/rust-libp2p/pull/3011 | ||
[PR 3055]: https://github.com/libp2p/rust-libp2p/pull/3055 | ||
[PR 3090]: https://github.com/libp2p/rust-libp2p/pull/3090 | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was missed in the previous #3085 sorry, should I add a new changelog entry CC @mxinden? (there was already one in the previous version mentioning the replacement of the methods for
Handler
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this change is breaking, right? Thus advocating for no changelog.
On a related note, shouldn't our CI have caught this? Shouldn't this have generated a deprecation warning and thus shouldn't CI have failed? Can you investigate this @jxs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this isn't a breaking change afaik, as they are only called by the
Behaviour
good point,
cargo
doesn't trigger deprecation warning on the implementation, only on the invocation IRC, do we have any code triggering calls to the methods?