Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autonat): Skip unparsable multiaddr #3363

Merged
merged 4 commits into from
Jan 24, 2023
Merged

fix(autonat): Skip unparsable multiaddr #3363

merged 4 commits into from
Jan 24, 2023

Conversation

jxs
Copy link
Member

@jxs jxs commented Jan 20, 2023

Description

With this commit libp2p-autonat no longer discards the whole remote payload in case an addr is unparsable, but instead logs the failure and skips the unparsable multiaddr.

See #3244 for details.

Notes

This now targets master

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden @jxs
fix(autonat): Skip unparsable multiaddr (libp2p#3351)
2ab4208 
With this commit `libp2p-autonat` no longer discards the whole remote payload in case an addr is
unparsable, but instead logs the failure and skips the unparsable multiaddr.

See libp2p#3244 for details.
@mxinden
Copy link
Member

mxinden commented Jan 20, 2023

The below seems to be the error:

  rust-libp2p-headxrust-libp2p-headwebrtc-dialer-1    | [2023-01-20T13:45:44Z WARN  webrtc::peer_connection::peer_connection_internal] failed to open data channel: there already exists a stream with identifier

@jxs jxs mentioned this pull request Jan 21, 2023
Merged
mxinden
mxinden approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error seems unrelated to this patch. I will merge and thus retrigger CI.

@thomaseizinger thomaseizinger changed the title fix(autonat): Skip unparsable multiaddr (#3351) fix(autonat): Skip unparsable multiaddr Jan 24, 2023
@mergify mergify bot merged commit 9e1f775 into libp2p:master Jan 24, 2023
@jxs
Copy link
Member Author

jxs commented Jan 25, 2023

The below seems to be the error:

  rust-libp2p-headxrust-libp2p-headwebrtc-dialer-1    | [2023-01-20T13:45:44Z WARN  webrtc::peer_connection::peer_connection_internal] failed to open data channel: there already exists a stream with identifier

it's also reproduced here, might you have a hunch on what this might be @melekes ?
Thanks!

@jxs
Copy link
Member Author

jxs commented Jan 25, 2023

opened webrtc-rs/webrtc#405

umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
@jxs
fix(autonat): Skip unparsable multiaddr (libp2p#3363)
25ee7d4 
With this commit `libp2p-autonat` no longer discards the whole remote payload in case an addr is unparsable, but instead logs the failure and skips the unparsable multiaddr.

See libp2p#3244 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jxs @mxinden @thomaseizinger