-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(identity): add From
& Into
for public keys
#3805
fix(identity): add From
& Into
for public keys
#3805
Conversation
… into identity-fix-into-publickey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this!
Direction looks good, I left some inline comments :)
From
& Into
for public keys
FYI: I slightly revised your description to make a better commit message once we merge this :) |
Thank you, I had the hardest time with this title 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating the comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience and incorporating the comments :)
and thank you for your reviews and suggestions @thomaseizinger! Learning more about rust-libp2p in 3 days than I could even imagine. |
Description
This patch removes the
version 0.2.0
for deprecations as libp2p-identity is only at0.1.1
and this can be confusing to the reader.It also adds
impl From<ed25519::PublicKey> for PublicKey
(et al.) so thatPublicKey::from(ed25519::PublicKey)
works.Fixes #3802.
Notes & open questions
Change checklist
rsa