Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(identity): add From & Into for public keys #3805

Merged
merged 17 commits into from
Apr 22, 2023

Conversation

DougAnderson444
Copy link
Contributor

@DougAnderson444 DougAnderson444 commented Apr 19, 2023

Description

This patch removes the version 0.2.0 for deprecations as libp2p-identity is only at 0.1.1 and this can be confusing to the reader.

It also adds impl From<ed25519::PublicKey> for PublicKey (et al.) so that PublicKey::from(ed25519::PublicKey) works.

Fixes #3802.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (deprecation notices)
  • I have added tests that prove my fix is effective or that my feature works rsa
  • A changelog entry has been made in the appropriate crates

@DougAnderson444 DougAnderson444 changed the title Identity fix into publickey (fixes #3802) fix:(libp2p-identity) from/into publickey + deprecation notes (fixes #3802) Apr 19, 2023
@DougAnderson444 DougAnderson444 changed the title fix:(libp2p-identity) from/into publickey + deprecation notes (fixes #3802) fix(libp2p-identity): from/into publickey + deprecation notes (fixes #3802) Apr 19, 2023
@DougAnderson444 DougAnderson444 changed the title fix(libp2p-identity): from/into publickey + deprecation notes (fixes #3802) fix(identity): from/into pubkey, deprecation notes Apr 19, 2023
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this!

Direction looks good, I left some inline comments :)

identity/CHANGELOG.md Outdated Show resolved Hide resolved
identity/CHANGELOG.md Outdated Show resolved Hide resolved
identity/CHANGELOG.md Outdated Show resolved Hide resolved
identity/src/keypair.rs Outdated Show resolved Hide resolved
identity/src/keypair.rs Outdated Show resolved Hide resolved
identity/src/keypair.rs Outdated Show resolved Hide resolved
identity/src/keypair.rs Outdated Show resolved Hide resolved
identity/src/peer_id.rs Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title fix(identity): from/into pubkey, deprecation notes fix(identity): add From & Into for public keys Apr 20, 2023
@thomaseizinger
Copy link
Contributor

FYI: I slightly revised your description to make a better commit message once we merge this :)

@DougAnderson444
Copy link
Contributor Author

FYI: I slightly revised your description to make a better commit message once we merge this :)

Thank you, I had the hardest time with this title 😆

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the comments :)

identity/CHANGELOG.md Outdated Show resolved Hide resolved
identity/src/keypair.rs Outdated Show resolved Hide resolved
identity/src/keypair.rs Outdated Show resolved Hide resolved
identity/src/keypair.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience and incorporating the comments :)

identity/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot merged commit e6f9d49 into libp2p:master Apr 22, 2023
@DougAnderson444
Copy link
Contributor Author

Thanks for your patience and incorporating the comments :)

and thank you for your reviews and suggestions @thomaseizinger! Learning more about rust-libp2p in 3 days than I could even imagine.

@DougAnderson444 DougAnderson444 deleted the identity-fix-into-publickey branch April 22, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(libp2p-identity) Confusing deprecation(s) on making PeerId from ed25519 PublicKey bytes
2 participants