feat(transport): Add GlobalOnly Transport implementation #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
changed the title
tcoratger
changed the title
tcoratger
changed the title
thomaseizinger
requested changes
Apr 25, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
mxinden
reviewed
Apr 26, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
|
Can you address the clippy and doc test failures? I think then we can merge this 🥳 |
@thomaseizinger Done |
mxinden
reviewed
May 11, 2023
There was a problem hiding this comment.
🙏 thanks @tcoratger. Upgraded downstream user mxinden/kademlia-exporter#292.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upstreams the
GlobalOnlytransport from @mxinden's kademlia-exporter to rust-libp2p.Source: https://github.com/mxinden/kademlia-exporter/blob/master/src/exporter/client/global_only.rs.
Resolves: #3669.
Notes & open questions
The Rust
is_global()function associated toIpv4AddrandIpv6Addrused in this implementation is unstable.The method chosen here is to include the implementation of
is_global()directly to the library to secure its implementation while waiting for the Rust issue to be resolved. Theis_global()is then constructed to refer to all addresses that are not contained in the following Special-Purpose Address lists:ipv4: https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml#note2ipv6: https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtmlChange checklist