-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(identity): make Keypair
and Publickey
opaque
#3866
feat(identity): make Keypair
and Publickey
opaque
#3866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Direction looks good to me, a few minor comments!
Thanks for all your contributions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didnt notice the PR. Its a great start here.
Since I am not able to make a comment on the line itself, In x25519.rs on line 129 make sure to change logic in X25519::linked
so it is using PublicKey::try_into_ed25519
Thank you for the additional help in reviewing @dariusc93, much appreciated! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work, looking forward to merging this, thank you!
A few minor comments but direction looks good.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cant comment on the line itself but on line 281 should be changed to KeypairInner::Ecdsa(key.into())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I am excited to land this!
Only a few more minor things :)
This pull request has merge conflicts. Could you please resolve them @tcoratger? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is a very exciting PR to land, it should make everything around Keypair
and PublicKey
much easier to use.
@thomaseizinger Thanks for your help, nice library to collaborate :) |
Hi! I've some API concerns about that change. It makes some of our code pretty hairy. Hope to discuss that problem and look for possible solutions! Thank you. |
Description
Keypair
andPublickey
are rendered opaque:Keypair
is replaced by a privateKeyPairInner
enum that is encapsulated inside theKeypair
pub struct
Publickey
is replaced by a privatePublickeyInner
enum that is encapsulated inside thePublickey
pub struct
Resolves #3860.
Notes & open questions
Change checklist