Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(libp2p): remove quic and webrtc re-export #4041

Merged
merged 2 commits into from
Jun 6, 2023
Merged

feat(libp2p): remove quic and webrtc re-export #4041

merged 2 commits into from
Jun 6, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

These two re-exports are deprecated because they are both in alpha status. Users should depend on them directly.

Related: #3647.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Jun 6, 2023
@mergify mergify bot merged commit 23d499b into master Jun 6, 2023
@mergify mergify bot deleted the feat/libp2p-remove-deprecated-items branch June 6, 2023 18:30
mxinden
mxinden reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shoot. I thought these were already gone. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

@mergify mergify[bot] mergify[bot] approved these changes

Assignees
No one assigned
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden