-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gossipsub): include in libp2p
meta crate when compiling for wasm
#4217
Conversation
63d0f93
to
2a2fa99
Compare
2a2fa99
to
331c798
Compare
This pull request has merge conflicts. Could you please resolve them @ozkanonur? 🙏 |
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
b0b7f99
to
e730c0d
Compare
Meta-note: Please don't delete the pull-request description template, our mergify automation relies on the markdown headers being present to extract the final commit message. |
libp2p
meta crate when compiling for wasm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Sorry that we missed this. With this change, our CI will now properly check that gossipsub actually continuous to compile for WASM!
Can you include a changelog entry in |
What about |
We just remove a comment there, right? I don't think that is a release-worth change. |
Ah my bad, just looked at the changes again. Yes that will need a bump too, well spotted! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some nits around formatting!
Signed-off-by: ozkanonur <work@onurozkan.dev>
9f8bf39
to
a0a3d76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch.
Since #3973, gossipsub now fully supports wasm targets. It functions properly when added as a dependency on its own. However, when trying to use it under libp2p by activating a feature, it's not possible and the compiler will raise an error like `unresolved import libp2p::gossipsub`. This pull request enables the use of gossipsub for wasm targets when it's activated as a feature of the libp2p dependency. Pull-Request: #4217.
Description
Since #3973, gossipsub now fully supports wasm targets. It functions properly when added as a dependency on its own. However, when trying to use it under libp2p by activating a feature, it's not possible and the compiler will raise an error like
unresolved import libp2p::gossipsub
. This pull request enables the use of gossipsub for wasm targets when it's activated as a feature of the libp2p dependency.