-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kad): reduce noise of "remote supports our protocol" log #4278
fix(kad): reduce noise of "remote supports our protocol" log #4278
Conversation
- downgrade log level for the remote kademlia protocol report - introduce connection_id for the handler to improve logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a changelog entry hinting at the reduced log-spam wouldn't hurt :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shamil-gadelshin !
- update change log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you look into the CI failures (ignoring clippy)? |
@shamil-gadelshin seems to be missing an update to |
Fixed that. |
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
- update swarm version to 0.43.3
There are a clippy (compiler bug) and flood_sub(operation was canceled) after fixing Cargo.lock and Cargo.toml files. |
The clippy bug is hopefully resolved soon. A PR for that landed just recently: rust-lang/rust-clippy#11190. We don't require clippy to be green for merging so that is okay. I restarted the floodsub job, seems to have been some network issues. Thank you for the PR! |
Yes, github was unresponsive at that time.
You're welcome! |
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
There seem to be some issues around mergify not being able to update the PR. Let's see if it works now. |
This PR changes the logging of the Kademlia connection handler related to the remote Kademlia mode changes: - Downgrade log level for the remote kademlia protocol report from `info` to `debug`. - Introduce connection_id for the handler to improve logging. Pull-Request: #4278.
Description
This PR changes the logging of the Kademlia connection handler related to the remote Kademlia mode changes:
info
todebug
.Change checklist