refactor: migrate upgrades to {In,Out}boundConnectionUpgrade
#4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
changed the title
{In,Out}boundConnectionUpgrade{In,Out}boundConnectionUpgrade
thomaseizinger
changed the title
{In,Out}boundConnectionUpgrade{In,Out}boundConnectionUpgrade
|
I think we should probably also migrate away from |
mxinden
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This needs to be done in one PR because we need to remove the blanket impl at the same time we add the new ones. I also chose to duplicate
SelectUpgradefor thelibp2p::SwarmBuilderbecause theSelectUpgradewithinlibp2p-coreis really only meant to be used for protocol upgrade (which will go away at some point). This tiny bit of code duplication doesn't hurt and will help us in the future.Resolves: #4521.
Notes & open questions
Change checklist