Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated libp2p-deflate #4729

Merged
merged 5 commits into from
Oct 26, 2023
Merged

chore: remove deprecated libp2p-deflate #4729

merged 5 commits into from
Oct 26, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Oct 26, 2023 •
edited
Loading

Description

Related: #4522.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Oct 26, 2023
@thomaseizinger thomaseizinger mentioned this pull request Oct 26, 2023
Merged
4 tasks
thomaseizinger
thomaseizinger commented Oct 26, 2023
View reviewed changes
libp2p/CHANGELOG.md Outdated Show resolved Hide resolved
mxinden
mxinden approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thomaseizinger
Copy link
Contributor Author

Hmm, there still seems to be some flakiness in those hole-punch tests 😭

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2023

This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏

@mergify mergify bot merged commit 51dd702 into master Oct 26, 2023
71 checks passed
@mergify mergify bot deleted the feat/remove-deflate branch October 26, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden