Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add SwarmBuilder::with_quic_config for TcpPhase #4821

Merged
merged 6 commits into from
Nov 10, 2023
Merged

fix: Add SwarmBuilder::with_quic_config for TcpPhase #4821

merged 6 commits into from
Nov 10, 2023

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Nov 8, 2023 •
edited by thomaseizinger
Loading

Description

Related: #4819.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

thomaseizinger
thomaseizinger approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case to the main builder.rs file please?

@oblique
Copy link
Contributor Author

oblique commented Nov 9, 2023

done

thomaseizinger
thomaseizinger approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

libp2p/src/builder.rs Show resolved Hide resolved
libp2p/src/builder.rs Outdated Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 9, 2023

This pull request has merge conflicts. Could you please resolve them @oblique? 🙏

thomaseizinger
thomaseizinger reviewed Nov 9, 2023
View reviewed changes
libp2p/CHANGELOG.md Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@oblique
Copy link
Contributor Author

oblique commented Nov 9, 2023

Is the CI stuck?

@thomaseizinger
Copy link
Contributor

Is the CI stuck?

I kicked it again. Weird that none of the jobs started!

@mergify mergify bot merged commit 2ecc7cf into libp2p:master Nov 10, 2023
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oblique @thomaseizinger @mxinden