feat(kad): only dial if not connected AND not dialing #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
I believe this is fine. Will let @thomaseizinger take a final look.
thomaseizinger
changed the title
thomaseizinger
changed the title
thomaseizinger
approved these changes
Jan 15, 2024
|
friendly ping @joshuef |
joshuef
force-pushed
the
UseDefaultDialConditionsMore
branch
from
89504b3 to
54d5966
Compare
|
Ah! forgot all about this. That's updated with master and a changelog entry added now 🙇 |
|
This pull request has merge conflicts. Could you please resolve them @joshuef? 🙏 |
|
cargo deny is unrelated, submitted #5293 to address it |
jxs
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking about our code and noticed we still used the old DialCondition (before the change to not dialling NOR connected as default) and thought I'd double check in libp2p.
These places looked a bit suss and we can perhaps rely on the defaults here?