fix(upnp): don't panic when gateway is dropped #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
force-pushed
the
fix-upnp-bug-gateway-dropped
branch
from
9232d80 to
8bc100b
Compare
|
I've noticed this last week and probably shouldve brought it up here but glad it is fixed :) |
Co-authored-by: Darius Clark <dariusc93@users.noreply.github.com>
jxs
added
the
trivial
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…ibp2p into fix-upnp-bug-gateway-dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There seems to be a situation when the
Behaviourand therefore it'sGatewayis dropped leaving thetokioloop to panic. It has been reported on sigp/lighthouse#5498, this attempts to fix it.Cc @dariusc93 can you review this please Darius? Thanks!
Change checklist