feat(websocket,websocket-websys): Add support for /tls/ws
#5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can not add reviewers, so I'm tagging you: @jxs @thomaseizinger |
oblique
changed the title
/tls/ws/tls/ws and keep /wss backward compatible
dariusc93
reviewed
Aug 3, 2024
|
This pull request has merge conflicts. Could you please resolve them @oblique? 🙏 |
jxs
changed the title
/tls/ws and keep /wss backward compatible/tls/ws
|
This pull request has merge conflicts. Could you please resolve them @oblique? 🙏 |
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
To keep backward compatibility the following rules were implemented: * On dialing, `/tls/ws` and `/wss` are equivalent. * On listening: * If user listens with `/tls/ws` then `/tls/ws` will be advertised. * If user listens with `/wss` then `/wss` will be advertised. Closes libp2p#2449 Closes libp2p#5509 Pull-Request: libp2p#5523.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To keep backward compatibility the following rules were implemented:
/tls/wsand/wssare equivalent./tls/wsthen/tls/wswill be advertised./wssthen/wsswill be advertised.Closes #2449
Closes #5509
Notes & open questions
Doing the change directly in
multiaddrcrate as multiformats/rust-multiaddr#100 suggests it would break compatibility and two different versions of libp2p that support websocket wouldn't be able to communicate. I decided to give the decision to the user by providing the listening address they want.This PR contains all changes of #5525 PR, so merge that one first.
Change checklist