-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(swarm): don't report NewExternalAddrCandidate
if already confirmed
#5582
base: master
Are you sure you want to change the base?
fix(swarm): don't report NewExternalAddrCandidate
if already confirmed
#5582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi François, this LGTM! CC @umgefahren wdyt?
…xternal-addresses
This PR is not marked |
…xternal-addresses
rust-libp2p/misc/quick-protobuf-codec/src/lib.rs Lines 14 to 16 in a2a2816
|
Description
Currently,
NewExternalAddrCandidate
events are emitted for every connections. However, we continue to get this event even whenautonat
has already confirmed that this address is external. So we should not continue to advertise the "candidate" event.Notes & open questions
We have made the changes in the
swarm
instead ofidentify
because it does not make it necessary to duplicate theConfirmedExternalAddr
vector in theidentify
Behaviour. Moreover, if any future Behaviour emitNewExternalAddrCandidate
, the same rule will also be applied.I had to edit the
autonat_v2
tests which were always expecting aNewExternalAddrCandidate
but the address was already confirmed.Change checklist