-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove WindowUpdateMode::OnReceive
#175
Comments
Sounds good to me! Perhaps make a point-release deprecating it first :) |
mxinden
added a commit
to mxinden/rust-yamux
that referenced
this issue
Nov 23, 2023
Continuation of libp2p#120. Preparation for libp2p#175. Also removes dead-lock warning for `WindowUpdateMode::OnRead`. With the restructuring of `Connection::poll`, one reads from the socket when writing is blocked. Thus the deadlock can not occur.
mxinden
added a commit
to mxinden/rust-yamux
that referenced
this issue
Nov 23, 2023
Follow up to previous deprecation libp2p#177. Fixes libp2p#175.
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I suggest we remove
WindowUpdateMode::OnReceive
in favor of always using (not just defaulting to)WindowUpdateMode::OnRead
.I can not think of a use-case where one would want
OnReceive
overOnRead
. Anyone?Removing
OnReceive
will simplify our codebase.rust-yamux/yamux/src/lib.rs
Lines 66 to 76 in 93b7062
The text was updated successfully, but these errors were encountered: