Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed EOF when reading from a stream and the FIN flag is received in a WindowUpdate frame #189

Closed
kkovaacs opened this issue May 31, 2024 · 0 comments · Fixed by #190
Closed

Missed EOF when reading from a stream and the FIN flag is received in a WindowUpdate frame #189

kkovaacs opened this issue May 31, 2024 · 0 comments · Fixed by #190

Comments

@kkovaacs
Copy link
Contributor

In case the FIN flag is received in a WindowUpdate frame the code does not wake up readers which can thus miss the stream EOF.

In connection::Active::on_window_update() readers are not woken up after setting the state to RecvClosed, thus potentially missing the EOF entirely.
@kkovaacs kkovaacs mentioned this issue May 31, 2024
Merged
@jxs jxs closed this as completed in #190 Jun 7, 2024
kkovaacs added a commit to eqlabs/pathfinder that referenced this issue Jun 13, 2024
@kkovaacs
chore(Cargo.lock): upgrade yamux to 0.13.3
0a43aec 
This version has the fix for the missed EOF issue triggered by
Golang peers. (libp2p/rust-yamux#189)
@kkovaacs kkovaacs mentioned this issue Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wake up readers after setting the state to RecvClosed kkovaacs/rust-yamux
1 participant
@kkovaacs