Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid race condition between pending frames and closing stream #156

Merged
merged 15 commits into from
May 24, 2023
Merged

fix: avoid race condition between pending frames and closing stream #156

merged 15 commits into from
May 24, 2023

Commits on May 19, 2023

  1. Add failing unit test for missing flush

    @thomaseizinger
    thomaseizinger committed May 19, 2023
    Configuration menu
    Copy the full SHA
    dce9ea5 View commit details
    Browse the repository at this point in the history

  2. Actually wait for flushing on yamux::Stream

    @thomaseizinger
    thomaseizinger committed May 19, 2023
    Configuration menu
    Copy the full SHA
    76a7e6f View commit details
    Browse the repository at this point in the history

  3. Flushing a closed stream is okay

    @thomaseizinger
    thomaseizinger committed May 19, 2023
    Configuration menu
    Copy the full SHA
    6c03282 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Use 1 channel per stream

    @thomaseizinger
    thomaseizinger committed May 22, 2023
    Configuration menu
    Copy the full SHA
    496613e View commit details
    Browse the repository at this point in the history

  2. Minimize diff

    @thomaseizinger
    thomaseizinger committed May 22, 2023
    Configuration menu
    Copy the full SHA
    ee3898a View commit details
    Browse the repository at this point in the history

  3. Introduce dedicated CommandReceivers

    @thomaseizinger
    thomaseizinger committed May 22, 2023
    Configuration menu
    Copy the full SHA
    53d90e4 View commit details
    Browse the repository at this point in the history

  4. Fix compile error in unit test

    @thomaseizinger
    thomaseizinger committed May 22, 2023
    Configuration menu
    Copy the full SHA
    09a660e View commit details
    Browse the repository at this point in the history

  5. Fix a bug where closing would hang forever

    @thomaseizinger
    thomaseizinger committed May 22, 2023
    Configuration menu
    Copy the full SHA
    4b5293b View commit details
    Browse the repository at this point in the history

  6. Replace garbage_collect with detecting closed receiver

    @thomaseizinger
    thomaseizinger committed May 22, 2023
    Configuration menu
    Copy the full SHA
    c6acd8e View commit details
    Browse the repository at this point in the history

  7. Correctly poll all receivers

    @thomaseizinger
    thomaseizinger committed May 22, 2023
    Configuration menu
    Copy the full SHA
    e0ec0aa View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Introduce TaggedStream so we can use SelectAll

    @thomaseizinger
    thomaseizinger committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e755c2c View commit details
    Browse the repository at this point in the history

  2. Inline poll_stream_receivers and remove ID from stream command

    @thomaseizinger
    thomaseizinger committed May 23, 2023
    Configuration menu
    Copy the full SHA
    fd810c4 View commit details
    Browse the repository at this point in the history

  3. Add comment about channel size

    @thomaseizinger
    thomaseizinger committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4060d07 View commit details
    Browse the repository at this point in the history

  4. Update docs

    @thomaseizinger
    thomaseizinger committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e809103 View commit details
    Browse the repository at this point in the history

  5. Reduce diff

    @thomaseizinger
    thomaseizinger committed May 23, 2023
    Configuration menu
    Copy the full SHA
    53d5ece View commit details
    Browse the repository at this point in the history