Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split the multiaddr change out of this spec #354

Merged
merged 2 commits into from
Jul 27, 2021
Merged

split the multiaddr change out of this spec #354

merged 2 commits into from
Jul 27, 2021

Conversation

marten-seemann
Copy link
Contributor

This PR goes with #353, and aim to split the multiaddr change into a separate change, unrelated to Protocol Select.

@marten-seemann marten-seemann marked this pull request as draft July 25, 2021 14:52
@marten-seemann marten-seemann mentioned this pull request Jul 25, 2021
Open
@mxinden mxinden mentioned this pull request Jul 26, 2021
Open
mxinden
mxinden reviewed Jul 26, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, other than that this looks good to me. Thanks for this pull request and #353.

protocol-select/README.md Outdated Show resolved Hide resolved
@marten-seemann @mxinden
add heading for Protocol Select connection establishment
7913830 
Co-authored-by: Max Inden <mail@max-inden.de>
mxinden
mxinden approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I think this can be merged, especially since the pull request is not targeting master but protocol-select.

@marten-seemann marten-seemann marked this pull request as ready for review July 27, 2021 07:26
@marten-seemann marten-seemann merged commit fc07c19 into protocol-select Jul 27, 2021
@marten-seemann marten-seemann mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
protocol-select
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @mxinden