circuitv2: specify timestamp units for reservation expiration #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reservation expiration date is specified in seconds so be explicit about that in the spec in the same way we are explicit about the duration limit units.
achingbrain
changed the title
marten-seemann
changed the title
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Mar 21, 2023
Spec update: libp2p/specs#531 Fixes #1635 which causes the circuit relay to repeatedly connect to a discovered relay. If the relay returns connection expiration in seconds, we get a negative ttl when calculating `expiration - new Date().getTime()`. This caused the `addRelay` function to set the timeout at 0ms which triggers instantly. --------- Co-authored-by: achingbrain <alex@achingbrain.net>
mxinden
reviewed
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reservation expiration date is specified in seconds so be explicit about that in the spec in the same way we are explicit about the duration limit units.