fix(versions): disable webrtc tests #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables the WebRTC tests for rust-libp2p v0.50.0 and v0.51.0 and chromium-js v0.41.0 and v0.42.0. Neither of these support the new `/webrtc-direct` (see multiformats/multiaddr#150 for context on rename). The missing support is blocking libp2p/rust-libp2p#3688 namely to upgrade to using `/webrtc-direct`. (Note that this is only blocking CI. Users can already use `/webrtc-direct` with the latest released rust-libp2p.) We will backport `/webrtc-direct` support to the rust-libp2p `v0.51.0` interop binary and then re-enable it here. I assume we can do the same for js-libp2p v0.42.0. Instead of disabling the versions with missing support for `/webrtc-direct` we could as well patch our interoperability test logic. For the sake of simplicity, I am proposing simply disabling the versions for now.
|
Is this because we are sending the address as a string and not as a binary? Because I thought that we didn't change the binary representation. |
This would first need a patch to all repos to actually try multiple addresses right? |
MarcoPolo
approved these changes
Mar 30, 2023
Documenting out-of-band discussion here. Yes, due to us using string representation. Long term I would be in favor of moving to binary representation. We agree that simply disabling is the best way forward. |
mxinden
added a commit
to mxinden/test-plans
that referenced
this pull request
Apr 12, 2023
See multiformats/multiaddr#150 (comment) for context on discussion. - Renames the `webrtc` transport identifier to `webrtc-direct`. - Re-enables `webrtc-direct` support for rust-libp2p v0.51. Previously disabled in libp2p#160. See libp2p/rust-libp2p#3781 for corresponding change on the rust-libp2p side. - Leaves JS v0.41 and v0.42 untouched. To be done in a follow-up alongside JS dependency updates.
MarcoPolo
pushed a commit
to mxinden/test-plans
that referenced
this pull request
Apr 13, 2023
This commit disables the WebRTC tests for rust-libp2p v0.50.0 and v0.51.0 and chromium-js v0.41.0 and v0.42.0. Neither of these support the new `/webrtc-direct` (see multiformats/multiaddr#150 for context on rename). The missing support is blocking libp2p/rust-libp2p#3688 namely to upgrade to using `/webrtc-direct`. (Note that this is only blocking CI. Users can already use `/webrtc-direct` with the latest released rust-libp2p.) We will backport `/webrtc-direct` support to the rust-libp2p `v0.51.0` interop binary and then re-enable it here. Instead of disabling the versions with missing support for `/webrtc-direct` we could as well patch our interoperability test logic. For the sake of simplicity, I am proposing simply disabling the versions for now.
mxinden
added a commit
that referenced
this pull request
Apr 19, 2023
See multiformats/multiaddr#150 (comment) for context on discussion. - Renames the `webrtc` transport identifier to `webrtc-direct`. - Re-enables `webrtc-direct` support for rust-libp2p v0.51. Previously disabled in #160. See libp2p/rust-libp2p#3781 for corresponding change on the rust-libp2p side. - Leaves JS v0.41 and v0.42 untouched. To be done in a follow-up alongside JS dependency updates.
mxinden
added a commit
to mxinden/test-plans
that referenced
this pull request
Apr 25, 2023
Copy of `multidim-interop/impl/js/v0.42` plus version adjustments + reenable WebRTC (see libp2p#160).
mxinden
added a commit
that referenced
this pull request
May 5, 2023
Copy of `multidim-interop/impl/js/v0.42` plus version adjustments + reenable WebRTC (see #160).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables the WebRTC tests for rust-libp2p v0.50.0 and v0.51.0 and chromium-js v0.41.0 and v0.42.0. Neither of these support the new
/webrtc-direct(see multiformats/multiaddr#150 for context on rename).The missing support is blocking libp2p/rust-libp2p#3688 namely to upgrade to using
/webrtc-direct. (Note that this is only blocking CI. Users can already use/webrtc-directwith the latest released rust-libp2p.) More concretely the latest rust-libp2pmastersends a/webrtc-directaddress as the listener to the dialer. The dialer (i.e. the versions listed above) do not support/webrtc-directand thus fail.We will backport
/webrtc-directsupport to the rust-libp2pv0.51.0interop binary and then re-enable it here. I assume we can not do the same in js-libp2p as it is released as a breaking change. @achingbrain is that correct?Instead of disabling the versions with missing support for
/webrtc-directwe could as well patch our interoperability test logic, e.g. send both/webrtcand/webrtc-directaddresses. For the sake of simplicity, I am proposing simply disabling the versions for now.@achingbrain @MarcoPolo @thomaseizinger do you have thoughts on this? Would you prefer a patch to the interop test binary logic?
Pull request updating js-libp2p-webrtc to support
/webrtc-direct: libp2p/js-libp2p-webrtc#100