Reintroduce js-libp2p v0.45.0 and fix build from cache #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Jun 5, 2023
| @@ -4,12 +4,16 @@ commitSha := 41641f1a7656aa654234f6f849b1749786867121 | |||
| # TODO Enable webkit once https://github.com/libp2p/js-libp2p/pull/1627 is in | |||
| all: image.json chromium-image.json firefox-image.json | |||
|
|
|||
| chromium-image.json: image.json BrowserDockerfile | |||
There was a problem hiding this comment.
The dependency of BrowserDockerfile is still valid, right? In other words, changing the BrowserDockerfile should lead to a rebuild of the chromium-image.json target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187 with an extra commit that fixes the builds from cache. The issue is that the browser images which are based on the node image for speed relied on the image being tagged with a certain name. When loading from cache we don't load the tag name again, just the image and reference it via the digest.
If we could reference base images by their digest that would have also fixed this issue.