Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test rust-libp2p rust-yamux v0.12 upgrade #247

Closed
wants to merge 9 commits into from

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Aug 1, 2023

Benchmark performance impact of rust-yamux v0.12 upgrade on rust-libp2p, more specifically libp2p/rust-libp2p#3013.

Benchmark performance impact of rust-yamux v0.12 upgrade on rust-libp2p, more
specifically libp2p/rust-libp2p#3013.
@mxinden
Copy link
Member Author

mxinden commented Aug 1, 2023

@thomaseizinger once https://github.com/libp2p/test-plans/actions/runs/5727165977/job/15519015306 finished you can see the results on the dashboard below. Make sure to scroll to the bottom to find a graph comparing rust-libp2p/v0.52 with rust-libp2p/yamux-v0.12.

https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=perf-rust-libp2p-yamux-v0.12

@thomaseizinger
Copy link
Contributor

@mxinden No space left on device :(

@mxinden
Copy link
Member Author

mxinden commented Aug 1, 2023

Thanks for the ping. Retriggered https://github.com/libp2p/test-plans/actions/runs/5727165977/job/15527780097. First time I see this issue. Do concurrent runs compete with disc-space on GitHub runners?

@thomaseizinger
Copy link
Contributor

Do concurrent runs compete with disc-space on GitHub runners?

Not that I am aware.

@thomaseizinger
Copy link
Contributor

Thanks for the ping. Retriggered https://github.com/libp2p/test-plans/actions/runs/5727165977/job/15527780097. First time I see this issue. Do concurrent runs compete with disc-space on GitHub runners?

Failed again :(

@thomaseizinger
Copy link
Contributor

I retriggered it with a reduced set of implementations, lets see if that helps: https://github.com/libp2p/test-plans/actions/runs/5738590877

@thomaseizinger
Copy link
Contributor

I retriggered it with a reduced set of implementations, lets see if that helps: libp2p/test-plans/actions/runs/5738590877

Failed again, I didn't realize that excluding them from the versions.ts file doesn't actually skip the build. cc @mxinden A feature-request? :)

@mxinden
Copy link
Member Author

mxinden commented Aug 4, 2023

@thomaseizinger results are now updated on https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=perf-rust-libp2p-yamux-v0.12.

Upload shows a slight improvement. Download does not. Without further digging I would expect this to be noise only. No regressions. Ready to go.

@mxinden
Copy link
Member Author

mxinden commented Aug 7, 2023

Closing here. Great to see this in action.

@mxinden mxinden closed this Aug 7, 2023
@mxinden mxinden deleted the perf-rust-libp2p-yamux-v0.12 branch August 7, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants