-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Test rust-libp2p rust-yamux v0.12 upgrade #247
Conversation
Benchmark performance impact of rust-yamux v0.12 upgrade on rust-libp2p, more specifically libp2p/rust-libp2p#3013.
@thomaseizinger once https://github.com/libp2p/test-plans/actions/runs/5727165977/job/15519015306 finished you can see the results on the dashboard below. Make sure to scroll to the bottom to find a graph comparing https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=perf-rust-libp2p-yamux-v0.12 |
@mxinden No space left on device :( |
Thanks for the ping. Retriggered https://github.com/libp2p/test-plans/actions/runs/5727165977/job/15527780097. First time I see this issue. Do concurrent runs compete with disc-space on GitHub runners? |
Not that I am aware. |
Failed again :( |
I retriggered it with a reduced set of implementations, lets see if that helps: https://github.com/libp2p/test-plans/actions/runs/5738590877 |
Failed again, I didn't realize that excluding them from the |
@thomaseizinger results are now updated on https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=perf-rust-libp2p-yamux-v0.12. Upload shows a slight improvement. Download does not. Without further digging I would expect this to be noise only. No regressions. Ready to go. |
Closing here. Great to see this in action. |
Benchmark performance impact of rust-yamux v0.12 upgrade on rust-libp2p, more specifically libp2p/rust-libp2p#3013.