Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stream limits and connection limits #53

Merged
merged 10 commits into from
Apr 15, 2023
Merged

Update stream limits and connection limits #53

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
92882b2
update rust deps
p-shahi Apr 14, 2023
3fe2dd4
update stream limits
p-shahi Apr 14, 2023
b226ef8
Merge branch 'main' of github.com:libp2p/universal-connectivity into …
p-shahi Apr 14, 2023
d415745
add comments
p-shahi Apr 14, 2023
41cd3a9
Merge branch 'main' of github.com:libp2p/universal-connectivity into …
p-shahi Apr 15, 2023
70229dc
Merge branch 'main' of github.com:libp2p/universal-connectivity into …
p-shahi Apr 15, 2023
565ae77
update limits
p-shahi Apr 15, 2023
817a5be
reduce maxconnections to 10
p-shahi Apr 15, 2023
e27b667
update min connections
p-shahi Apr 15, 2023
13c0675
rm connection manager configs
p-shahi Apr 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 18 additions & 9 deletions packages/frontend/src/lib/libp2p.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,22 @@ import { BOOTSTRAP_NODE, CHAT_TOPIC, CIRCUIT_RELAY_CODE } from './constants'
import * as filters from "@libp2p/websockets/filters"

// @ts-ignore
import { circuitRelayTransport, circuitRelayServer } from 'libp2p/circuit-relay'
import { circuitRelayTransport } from 'libp2p/circuit-relay'


export async function startLibp2p() {
// localStorage.debug = 'libp2p*,-*:trace'
// application-specific data lives in the datastore

// libp2p is the networking layer that underpins Helia
const libp2p = await createLibp2p({
dht: kadDHT({protocolPrefix: "/universal-connectivity", maxInboundStreams: 100, maxOutboundStreams: 100, clientMode: true}),
// set the inbound and outbound stream limits to these values
// because we were seeing a lot of the default limits being hit
dht: kadDHT({
protocolPrefix: "/universal-connectivity",
maxInboundStreams: 5000,
maxOutboundStreams: 5000,
clientMode: true
}),
transports: [webTransport(), webSockets({
filter: filters.all,
}), webRTC({
Expand All @@ -45,8 +51,8 @@ export async function startLibp2p() {
}),],
connectionEncryption: [noise()],
connectionManager: {
maxConnections: 200,
minConnections: 1,
maxConnections: 10,
minConnections: 50,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minConnections needs to be less than maxConnections.

Is there a reason you're overriding this? If not I'd just remove the whole connectionManager block.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, I'm not sure why it was added. @maschad any idea?

streamMuxers: [yamux()],
peerDiscovery: [
Expand All @@ -64,12 +70,15 @@ export async function startLibp2p() {
ignoreDuplicatePublishError: true,
}),
identify: {
maxPushOutgoingStreams: 100,
maxInboundStreams: 100,
maxOutboundStreams: 100,
// these are set because we were seeing a lot of identify and identify push
// stream limits being hit
maxPushOutgoingStreams: 1000,
maxPushIncomingStreams: 1000,
maxInboundStreams: 1000,
maxOutboundStreams: 1000,
Comment on lines +69 to +74
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned by this. These limits are per connection, this means you're allowing 1000 identify streams to be open at the same time on each connection.

If you're seeing errors it sounds like something's not cleaning up the streams.

Maybe related: libp2p/js-libp2p#1424

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do what you have to to appease the demo gods though - this is more of a note to self to investigate.

Copy link
Member Author

@p-shahi p-shahi Apr 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the upper bounds here are crazy, but we were hitting the limits quite often so set it arbitrarily high

},
autonat: {
startupDelay: 60 * 60 *24 * 1000,
startupDelay: 60 * 60 * 24 * 1000,
},
})

Expand Down