Fix failing job on gcc 11 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nbelakovski
force-pushed
the
fix_gcc_11_windows
branch
from
0ae7c89
to
64f1b74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a comment in the .yml which describes the fix, but basically setup-fortran doesn't quite set up gcc 11 correctly. It's not quite their fault since the windows-latest image contains gcc 12 by default so they need to work around that and they didn't quite do it correctly.
What was happening is that the programs would get compiled with gcc 11, but when they ran, due to issues with how the PATH was set up, they would try to link against libgfortran-5.dll that was compiled with gcc 12 and this led to a crash. I tried to fix the PATH issues, but was unable to, so I decided to just rename the gcc 12 version of the dll so that it wouldn't get picked up.
I also noticed that the base image does not provide ninja, nor were the windows runners installing it explicitly. I'm not sure how it was installed, I think as a side effect of the setup-fortran action, but in any case I got some errors due to ninja not being installed so I went ahead and installed it explicitly.
Lastly I added the bash shell during some of my testing and I thought it was best to leave it there so that we can use bash across all 3 platforms for any future work.
This obviously supercedes #115