Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIP Support #216

Merged
merged 4 commits into from
May 15, 2022
Merged

PIP Support #216

merged 4 commits into from
May 15, 2022

Conversation

janisslsm
Copy link
Contributor

@janisslsm janisslsm commented May 14, 2022 •
edited
Loading

Adds support for PIP (Picture-in-Picture). Currently supports android Oreo (8) and above as lower versions require a workaround.
Closes #59

Bnyro
Bnyro approved these changes May 14, 2022
View reviewed changes
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and code looks good :)

@FireMasterK FireMasterK merged commit 6930984 into libre-tube:master May 15, 2022
@janisslsm janisslsm deleted the pip-experiment branch May 15, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Picture-in-picture (PiP) support
3 participants
@janisslsm @Bnyro @FireMasterK