Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio mode] Show video options when clicking thumbnail #2830

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

Bnyro
Copy link
Member

@Bnyro Bnyro commented Jan 22, 2023

No description provided.

@Bnyro Bnyro merged commit 7884edc into libre-tube:master Jan 22, 2023
@NeeRaj-2401
Copy link
Contributor

NeeRaj-2401 commented Jan 22, 2023

@Bnyro I guess this commit should be reverted cause
Video options such as
Play in background, play next, add to queue, (as we are already playing that song in background )
Share ( already have that option below thumbnail)
All these are no needed at all.

So we r left with only download and add to playlist
And if u will keep the download then there will be demand for download audio only etc.

The only option remaining is to keep that add to playlist part which can be adjusted with the other options i.e. below thumbnail

@Bnyro
Copy link
Member Author

Bnyro commented Jan 22, 2023

Well, I didn't find an other place for the download and add to playlist option and that was by far the easiest way to implement it.

@NeeRaj-2401
Copy link
Contributor

So while implementing eliminating the rest would be helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants