Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LifecycleService. #2993

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Conversation

Isira-Seneviratne
Copy link
Collaborator

Use the LifecycleService class with the download and background mode services.

@Bnyro
Copy link
Member

Bnyro commented Feb 8, 2023

So if I understand it correctly, this will allow us to use view models in these services?

@Isira-Seneviratne
Copy link
Collaborator Author

So if I understand it correctly, this will allow us to use view models in these services?

No, they allow any launched coroutines to be bound to the service's life cycle.

@Bnyro
Copy link
Member

Bnyro commented Feb 8, 2023

Oh, my bad, I mixed up lifecycleOwner and viewLifecycleOwner ;)

@Bnyro Bnyro merged commit 793ad8e into libre-tube:master Feb 8, 2023
@Isira-Seneviratne Isira-Seneviratne deleted the LifecycleService branch February 9, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants