Fix no connection with gnirehtet reverse tethering #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linus789
force-pushed
the
fix-rt-connection
branch
from
2ea8541
to
34ef14a
Compare
|
Do I need to pass the reviewdog? |
|
Would be good, yes, please run |
|
Otherwise if you can't get ktlint running I can do that too before merging :) |
Linus789
force-pushed
the
fix-rt-connection
branch
2 times, most recently
from
9d9d8af
to
1f68eef
Compare
Linus789
commented
Feb 18, 2023
app/src/main/java/com/github/libretube/helpers/NetworkHelper.kt
Outdated
Show resolved
Hide resolved
Linus789
force-pushed
the
fix-rt-connection
branch
from
1f68eef
to
e10b1ae
Compare
Linus789
force-pushed
the
fix-rt-connection
branch
from
e10b1ae
to
09ad638
Compare
Bnyro
approved these changes
Feb 20, 2023
|
Stills seems to work as expected, thanks! I hope some others using a VPN can test the debug builds in the next time just to make sure it still works for them, since we had issues with that earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m not too sure why the old code was commented out, so please take a look if it’s done right this time. Now it doesn’t say anymore that I have no connection if I’m using Gnirehtet.