Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CompactDecimalFormat to format counts. #3385

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

Isira-Seneviratne
Copy link
Collaborator

Use CompactDecimalFormat to format counts on Android 7.0 and later.

Screenshots

Before

Screenshot_20230325_190050_LibreTube

After

Screenshot_20230325_190101_LibreTube Debug

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, pretty unfortunate that it didn't get added before SDK 24.

@Bnyro Bnyro merged commit 777d33a into libre-tube:master Mar 25, 2023
@Isira-Seneviratne
Copy link
Collaborator Author

That looks great, pretty unfortunate that it didn't get added before SDK 24.

The ICU4J library could be included for older Android versions: https://developer.android.com/guide/topics/resources/internationalization

@Bnyro
Copy link
Member

Bnyro commented Mar 25, 2023

The ICU4J library could be included for older Android versions: https://developer.android.com/guide/topics/resources/internationalization

Hmm, I don't think that would be worth the trouble.

@Isira-Seneviratne Isira-Seneviratne deleted the CompactDecimalFormat branch March 26, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants