Fix dark status bar icons when player is in fullscreen

[anilbeesetti]

Before:

After:

[Isira-Seneviratne]

Looks like the method names should be swapped.

[anilbeesetti]

They are correct. Here we have to change the statusbar icon color but there's no direct method to change icon color directly. So if we set the statusbar as light then icons will be dark

[Isira-Seneviratne]

Right, missed that.

Edit: Instead of adding these extensions, you could just create a WindowInsetsControllerCompat in the fragment itself and reuse it as needed.

[anilbeesetti]

Yes we can do that. It's just a preference. By doing what you suggested the code is not reusable and using functions make code more readable in my opinion

[Isira-Seneviratne]

True, but it's not like the code is being used anywhere else in your changeset. If it needs to be used in other places as well, it can be easily refactored.

[Isira-Seneviratne]

Suggested change

	// set status bar icon color to white
	mainActivity.setLightStatusBarIcons()
	// set status bar icon color to white
	windowInsetsControllerCompat.isAppearanceLightStatusBars = false

The WindowInsetsControllerCompat object used here could be created/destroyed in the relevant fragment lifecycle callbacks (onCreate, onDestroy), like with the fragment's view binding.

[Isira-Seneviratne]

Suggested change

	if (mainActivity.isLightTheme) {
	mainActivity.setDarkStatusBarIcons()
	} else {
	mainActivity.setLightStatusBarIcons()
	}
	windowInsetsControllerCompat.isAppearanceLightStatusBars = when (resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK) {
	Configuration.UI_MODE_NIGHT_YES -> false
	Configuration.UI_MODE_NIGHT_NO -> true
	else -> true
	}

[Isira-Seneviratne]

Looks good to me.

[Bnyro]

Thank you!