Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to AGP 8.0. #3585

Merged
merged 10 commits into from
May 10, 2023
Merged

Upgrade to AGP 8.0. #3585

merged 10 commits into from
May 10, 2023

Conversation

Isira-Seneviratne
Copy link
Collaborator

  • Update the Android Gradle Plugin to 8.0.
  • Set the JDK version to 17.
  • Remove some unnecessary API suppressions (the lint issue is not present on Android Studio Flamingo).

@Isira-Seneviratne
Copy link
Collaborator Author

There seems to be an issue with the CodeQL action, as it mentions in the log that Java 11 is being used instead of 17.

@MatsG23
Copy link

MatsG23 commented Apr 24, 2023

You can setup JDK 17 in the CodeQL Action using actions/setup-java. It should use that version of Java for the task autobuild then.

See: github/codeql-action#825 (comment)

@MatsG23
Copy link

MatsG23 commented Apr 24, 2023

Just as you did in the ci.yml file.

@MatsG23
Copy link

MatsG23 commented Apr 24, 2023

BTW, do you have a reason to use version 8.0.0 of the Gradle build tool? That version was released on 13th February. Since then there was some patch releases. The latest version is Gradle 8.1.1.

@Bnyro
Copy link
Member

Bnyro commented Apr 24, 2023

Android Studio does not yet support the latest AGP version as far as I know.

@MatsG23
Copy link

MatsG23 commented Apr 24, 2023 via email

@Isira-Seneviratne
Copy link
Collaborator Author

BTW, do you have a reason to use version 8.0.0 of the Gradle build tool? That version was released on 13th February. Since then there was some patch releases. The latest version is Gradle 8.1.1.

It's required by AGP 8.0.

@MatsG23
Copy link

MatsG23 commented Apr 25, 2023

AGP requires Gradle 8.0 as a minimum version. It is not pinned on a specific version of Gradle. It is officially recommended to use the latest Gradle version with AGP for "performance reasons".
The newer releases also include bug fixes, stabilize the config cache feature (in this case) and may fix security vulnerabilities.
You cannot use a newer AGP version like 8.1 with the stable version of Android Studio (Flamingo) but that is a different thing.

@Bnyro
Copy link
Member

Bnyro commented Apr 25, 2023

That makes sense, however we need to make sure F-Droid supports later versions of gradle than 8.0 too, recently we weren't updated on F-Droid for a month due to bumping the gradle version to one that's not been supported by F-Droid.

@Bnyro
Copy link
Member

Bnyro commented Apr 27, 2023

Unfortunately I'm not able to test this because I'm using IntelliJ which doesn't yet support the AGP 8.0. I'll probably need to switch to Android Studio then, which however is unfortunately not part of my distro's package repos.
So apologies for the delay, I'll see whether I can find an other way, e.g. to update the Android Plugin in IntelliJ.

@Bnyro
Copy link
Member

Bnyro commented May 10, 2023

I've tested the changes and it now seems to be all good to me, the only thing we should get running before merging is CodeQL.

@Bnyro
Copy link
Member

Bnyro commented May 10, 2023

Thanks @FireMasterK and @Isira-Seneviratne

@Bnyro Bnyro merged commit 9dcdda2 into libre-tube:master May 10, 2023
@Isira-Seneviratne Isira-Seneviratne deleted the AGP_8.0 branch May 12, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants