-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to AGP 8.0. #3585
Upgrade to AGP 8.0. #3585
Conversation
Isira-Seneviratne
commented
Apr 18, 2023
- Update the Android Gradle Plugin to 8.0.
- Set the JDK version to 17.
- Remove some unnecessary API suppressions (the lint issue is not present on Android Studio Flamingo).
0ebc23e
to
a080526
Compare
11afe35
to
040c504
Compare
040c504
to
6c146f7
Compare
There seems to be an issue with the CodeQL action, as it mentions in the log that Java 11 is being used instead of 17. |
You can setup JDK 17 in the CodeQL Action using actions/setup-java. It should use that version of Java for the task |
Just as you did in the ci.yml file. |
BTW, do you have a reason to use version 8.0.0 of the Gradle build tool? That version was released on 13th February. Since then there was some patch releases. The latest version is Gradle 8.1.1. |
Android Studio does not yet support the latest AGP version as far as I know. |
I am talking of Gradle, not the Android Gradle Plugin (AGP).
…-------- Original-Nachricht --------
Am 24. Apr. 2023, 17:40, schrieb Bnyro :
Android Studio does not yet support the latest AGP version as far as I know.
—
Reply to this email directly, [view it on GitHub](#3585 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AOONGXKBS4UOVYNJURR23XTXC2NGJANCNFSM6AAAAAAXB5FZXI).
You are receiving this because you commented.Message ID: ***@***.***>
|
It's required by AGP 8.0. |
AGP requires Gradle 8.0 as a minimum version. It is not pinned on a specific version of Gradle. It is officially recommended to use the latest Gradle version with AGP for "performance reasons". |
That makes sense, however we need to make sure F-Droid supports later versions of gradle than 8.0 too, recently we weren't updated on F-Droid for a month due to bumping the gradle version to one that's not been supported by F-Droid. |
Unfortunately I'm not able to test this because I'm using IntelliJ which doesn't yet support the AGP 8.0. I'll probably need to switch to Android Studio then, which however is unfortunately not part of my distro's package repos. |
I've tested the changes and it now seems to be all good to me, the only thing we should get running before merging is CodeQL. |
Thanks @FireMasterK and @Isira-Seneviratne |