Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stream notifications #3715

Merged
merged 2 commits into from
May 6, 2023
Merged

Improve stream notifications #3715

merged 2 commits into from
May 6, 2023

Conversation

Isira-Seneviratne
Copy link
Collaborator

@Isira-Seneviratne Isira-Seneviratne commented May 5, 2023 •
edited
Loading

  • Use the stream/channel IDs as unique notification identifiers to avoid having to keep track of the active notification count.
  • Avoid creating intermediate lists when filtering the new streams for which notifications should be created.

Bnyro
Bnyro approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better than the previous approach, awesome!

@Isira-Seneviratne Isira-Seneviratne merged commit c8739a7 into libre-tube:master May 6, 2023
@Isira-Seneviratne Isira-Seneviratne deleted the Notification_improvements branch May 9, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isira-Seneviratne @Bnyro