Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable search closing when user press back while playing video #3822

Merged
merged 1 commit into from
May 24, 2023

Conversation

SajalRG
Copy link
Contributor

@SajalRG SajalRG commented May 24, 2023

Issue #1965:

  • Search for something
  • Play the video
  • Clicking back btn would close the search also

Fix:
Disable auto close of search in onMenuItemActionCollapse method call. Search will close when search fragment is removed.

Known Issues:
Search will still close when player fragment is closed.

Issue libre-tube#1965:
* Search for something
* Play the video
* Clicking back btn would close the search also

Fix:
Disable auto close of search in onMenuItemActionCollapse method call.
Search will close when search fragment is removed.

Known Issues:
Search will still close when player fragment is closed.
@SajalRG
Copy link
Contributor Author

SajalRG commented May 24, 2023

Device: Pixel 2 API 32 emulator with GMS
Cases tested:

  • Press back in player screen
  • Minimize while playing video by dragging
  • Press back when in search result (should close)
good-case-compressed.mp4

Known Issues (still present):

  • Close player window
  • Switch different video in search screen
known-issues-compressed.mp4

@Bnyro
Copy link
Member

Bnyro commented May 24, 2023

Works fine from my tests, maybe @rozari0, @xIUPITERx and/or @akano12 want to give it a try too?

@Silther
Copy link
Contributor

Silther commented May 24, 2023

how can I try it, has it already been released as a debug version or is there an apk somewhere else?

@rozari0
Copy link
Contributor

rozari0 commented May 24, 2023

how can I try it, has it already been released as a debug version or is there an apk somewhere else?

Download the artifact from here.

@akano12
Copy link
Collaborator

akano12 commented May 24, 2023

Works fine on my side too, tapping back button doesn't clear the text controller anymore

@Bnyro
Copy link
Member

Bnyro commented May 24, 2023

Merging it then, thanks for your contribution!

(And of course thanks to everyone who tested it)

@Bnyro Bnyro merged commit c6c3614 into libre-tube:master May 24, 2023
@SajalRG SajalRG deleted the search-collapse-fix branch May 24, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants