Option to fall back to Piped proxy when Piped proxy disabled and video unreachable #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
force-pushed
the
fallback-piped-proxy
branch
4 times, most recently
from
c69515f
to
2fbf206
Compare
Bnyro
changed the title
FireMasterK
reviewed
Jun 30, 2023
|
Is there a video to test this with? For me it appears that YT music videos work as expected even without the Proxy somehow? |
Bnyro
force-pushed
the
fallback-piped-proxy
branch
from
12a368c
to
b69d2ab
Compare
Bnyro
force-pushed
the
fallback-piped-proxy
branch
2 times, most recently
from
818f9d8
to
ada94e0
Compare
Bnyro
force-pushed
the
fallback-piped-proxy
branch
from
1497478
to
10c9978
Compare
|
I'm currently getting an error at the bottom of the screen when opening any song in the "YT Music Songs" search filter, "Initial player response is not valid" This error message appears regardless of the song selected or combination of options of piped proxy enabled/disabled and fallback enabled/disabled. |
|
Try a different instance, see TeamPiped/Piped#2487 |
|
That's not related to the changes in this PR. |
|
Thanks for the info - I can confirm this works great after I switched the instance over to projectsegfau.lt and do not notice any issues specific to this now. |
|
Alright, thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4038