Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color segments depending on what type they are #4055

Merged
merged 12 commits into from
Jun 22, 2023

Conversation

general-a
Copy link
Contributor

@general-a general-a commented Jun 19, 2023

closes #4054 and closes #4061

@Bnyro
Copy link
Member

Bnyro commented Jun 20, 2023

Could you please turn this into an option? I'd prefer using the same color (which fits the theme) for all of them personally.

@general-a general-a requested a review from Bnyro June 21, 2023 14:11
@Bnyro
Copy link
Member

Bnyro commented Jun 21, 2023

Please remove the blank lines everywhere where reviewdog complains here, it's not common to add two blank lines between functions or blank lines after a closed curly bracket.

@Bnyro
Copy link
Member

Bnyro commented Jun 21, 2023

Code looks good to me now (didn't yet test the changes though)

@NeeRaj-2401
Copy link
Contributor

(didn't yet test the changes though)

i did a clean install to this debug > toggled segment colors ON in settings > restarted the app > played this video

here is the results :(

but later i went through
sponsor settings > clicked the green color (assigned for sponsor sections) > clicked 'OK' > started same video again

here is the results :)

as u can see the last section is still white, cause it wasn't touched by me in settings
if i would repeat the above step again with all the colors and categories then

hence, the problem is its not taking the default value.

@general-a
Copy link
Contributor Author

Odd, I'll do some debugging later to see what the issue is

@general-a
Copy link
Contributor Author

i did a clean install to this debug > toggled segment colors ON in settings > restarted the app > played this video

Patched this

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Bnyro Bnyro merged commit 2e56db0 into libre-tube:master Jun 22, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to only display SponsorBlock segments on time bar Color SponsorBlock segments by type
4 participants