-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color segments depending on what type they are #4055
Conversation
Could you please turn this into an option? I'd prefer using the same color (which fits the theme) for all of them personally. |
app/src/main/java/com/github/libretube/ui/views/ColorPreference.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/views/ColorPreference.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/views/ColorPreference.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/views/ColorPreference.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/views/ColorPreference.kt
Outdated
Show resolved
Hide resolved
Please remove the blank lines everywhere where reviewdog complains here, it's not common to add two blank lines between functions or blank lines after a closed curly bracket. |
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/views/ColorPreference.kt
Outdated
Show resolved
Hide resolved
Code looks good to me now (didn't yet test the changes though) |
i did a clean install to this debug > toggled segment colors ON in settings > restarted the app > played this video but later i went through as u can see the last section is still white, cause it wasn't touched by me in settings hence, the problem is its not taking the default value. |
Odd, I'll do some debugging later to see what the issue is |
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/views/ColorPreference.kt
Outdated
Show resolved
Hide resolved
Patched this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
closes #4054 and closes #4061