-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseline profile generation #5414
Add baseline profile generation #5414
Conversation
345a842
to
808be69
Compare
wow, pr so advanced that i couldn't understand what the code is doing (ik making app fast somehow) and the pixel props included (for what?), maybe @RafaelsRamos can drop his 2 cents here with good explanation. |
It allows a profile of methods called during startup to be generated, so that they can be compiled ahead of time to improve startup and overall performance on Android 7.0 and later: https://android-developers.googleblog.com/2022/01/improving-app-performance-with-baseline.html |
i understood now, but why pixel virtual device prop is needed for tests and why source compat and jvm target of baseline is not jdk 17 (LTS) but 1_8 ,different from Libretube |
The source compact can be Regarding the virtual device, the way the baseline profile generates the profiles, is by pre-compiling classes and methods from flows we want him to optimize (startup on this PR). This must be done on rooted devices (rooted emulators or physical devices). The reason why we want it on an emulator is because it should be ran before a new release, so adding it to the release pipeline would be the ultimate goal. |
Question - While generating the baseline-prof.txt I see that the content is not obfuscated. Did you use the I see that Google suggests using a .pro file with |
Yeah, the profile generation does that: https://developer.android.com/topic/performance/baselineprofiles/create-baselineprofile
There's already a |
# Conflicts: # gradle/libs.versions.toml
Add module for generating a baseline profile for the app.