fix: ResettableLazyManager not being reset on changing instances. #5480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
InstanceSettings.kt, the functioninstancePref.setOnPreferenceChangeListeneris not being invoked, despite assignmentpreference.value = selectedInstanceon L192. This results onResettableLazyManagernot being reset, leading to the API not being reloaded, to take into account the new instance selected.Issue replication
replication.mp4
What does this PR do?
ResettableLazyManageris reset when a new instance is selected. (Please validate my approach)Showcase
fixed.mp4
Please let me know if you see a better approach to fixing the issue.