Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for downloading whole playlist at once #5525
feat: support for downloading whole playlist at once #5525
Changes from all commits
16c7986
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 66 in app/src/main/java/com/github/libretube/LibreTubeApp.kt
GitHub Actions / Check Code Quality
Check failure on line 71 in app/src/main/java/com/github/libretube/LibreTubeApp.kt
GitHub Actions / Check Code Quality
Check failure on line 39 in app/src/main/java/com/github/libretube/constants/IntentData.kt
GitHub Actions / Check Code Quality
Check failure on line 40 in app/src/main/java/com/github/libretube/constants/IntentData.kt
GitHub Actions / Check Code Quality
Check failure on line 41 in app/src/main/java/com/github/libretube/constants/IntentData.kt
GitHub Actions / Check Code Quality
Check failure on line 42 in app/src/main/java/com/github/libretube/constants/IntentData.kt
GitHub Actions / Check Code Quality
Check failure on line 27 in app/src/main/java/com/github/libretube/services/PlaylistDownloadEnqueueService.kt
GitHub Actions / Check Code Quality
Check failure on line 48 in app/src/main/java/com/github/libretube/services/PlaylistDownloadEnqueueService.kt
GitHub Actions / Check Code Quality
Check failure on line 48 in app/src/main/java/com/github/libretube/services/PlaylistDownloadEnqueueService.kt
GitHub Actions / Check Code Quality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than having this here as a magic number, would it make sense to create an enum somewhere else along with other notification IDs? It's difficult to understand why 3 is used otherwise. (I'm guessing 1 and 2 are used elsewhere in the app)
This could be another PR perhaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should probably do thay in an other PR. 1 and 2 are used for the player and the normal download notification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to bring up the debate on having different default values. Additionally, do you think it may be worth saving on shared prefs the previously used settings in the future? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in the future. We already do this for the normal download dialog, but I wanted to keep this PR simple and basic for now.