Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MainActivity.kt #559

Merged
merged 3 commits into from
Jun 18, 2022
Merged

Update MainActivity.kt #559

merged 3 commits into from
Jun 18, 2022

Conversation

NeeRaj-2401
Copy link
Contributor

Just wanted the sponsors section and its notification to be enabled by default in which ONLY sponsor category has to be enabled by dafault.. others can be enabled manually.
but this change was necessary because the api itself is made for this intension

Just wanted the sponsors section and its notification to be enabled by default in which ONLY sponsor category has to be enabled by dafault.. others can be enabled manually.
but this change was necessary because the api itself is made for this intension
@Bnyro
Copy link
Member

Bnyro commented Jun 18, 2022

That's a good idea but we'll have to change some other code for it too :)

@Bnyro
Copy link
Member

Bnyro commented Jun 18, 2022

You'll have to add 'defaultValue="true"' to all the categories you want to enable in app/src/main/res/xml/sponsorblock_settings.xml

@NeeRaj-2401
Copy link
Contributor Author

ok let me just check it once

@Bnyro
Copy link
Member

Bnyro commented Jun 18, 2022

The lines you changed shouldn't really have an impact on what you want to achieve :)

@Bnyro
Copy link
Member

Bnyro commented Jun 18, 2022

Feel free to ask me if you have questions :)

tried defaultValue="true" at needed places
@NeeRaj-2401
Copy link
Contributor Author

i made some changes there.. please check it out

@Bnyro
Copy link
Member

Bnyro commented Jun 18, 2022

looks good :)
I think we could also enable sponsorblock itself and its notifications by default (if you want to do so)

@NeeRaj-2401
Copy link
Contributor Author

NeeRaj-2401 commented Jun 18, 2022

yes i want to do that
basically

  1. sponsorblock
  2. its notifications
  3. only sponsor category
    i want these three toggles to be enabled by default

@Bnyro
Copy link
Member

Bnyro commented Jun 18, 2022

Oh, you enabled that already, I'm just brain afk :p

@NeeRaj-2401

This comment was marked as off-topic.

@Bnyro Bnyro merged commit 45d4e5e into libre-tube:master Jun 18, 2022
@Bnyro
Copy link
Member

Bnyro commented Jun 18, 2022

sure :)

@NeeRaj-2401
Copy link
Contributor Author

thanks for the help budyy !!

@Bnyro
Copy link
Member

Bnyro commented Jun 18, 2022

no problem, feel free to join us on Element (preferred) or Telegram (links are in the Readme). Communication is easier there :)

@NeeRaj-2401
Copy link
Contributor Author

yeah, i have already joined Libretube and Libretube Alpha over telegram...

@Bnyro
Copy link
Member

Bnyro commented Jun 18, 2022

these are only announcement channels, for discussions you should join t.me/libretubechat

@NeeRaj-2401
Copy link
Contributor Author

sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants