fix: hide thumbnail space, buttons and filters when playlist empty #5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-conder
commented
Mar 18, 2024
There was a problem hiding this comment.
e84b8e5 there is a typo in the title, *sortTV is not visible when playlists are missing
Bnyro
reviewed
Mar 19, 2024
app/src/main/java/com/github/libretube/ui/fragments/PlaylistFragment.kt
Outdated
Show resolved
Hide resolved
Bnyro
reviewed
Mar 19, 2024
app/src/main/java/com/github/libretube/ui/fragments/PlaylistFragment.kt
Outdated
Show resolved
Hide resolved
Bnyro
reviewed
Mar 19, 2024
|
Thanks for the PR, just some small nitpicks 👍 |
|
Please push the changes suggested in my review when you have time. |
Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>
Bnyro
approved these changes
Mar 20, 2024
Bnyro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in addition to the correction in the playlist, there is also a correction in the library itself, if there are no playlists at all: sorting is hidden there e84b8e5.
Here's what it looks like: