Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when importing subscriptions list with invalid avatars #5931

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

bodaciousbiscuits
Copy link
Contributor

Solves issue of subscription list not loading when channels have old/invalid avatars.

See issue below:

video_2024-04-17_17-00-22.mp4

Solves issue of subscription list not loading when channels have old/invalid avatars.
@bodaciousbiscuits
Copy link
Contributor Author

While debugging the problem, the null pointer showed up in the logs:

04-17 07:51:48.227 19814  4443 E kotlinx.coroutines.StandaloneCoroutine: kotlinx.serialization.json.internal.JsonDecodingException: Unexpected JSON token at offset 27191: Expected string literal but 'null' literal was found at path: $[111].avatar
04-17 07:51:48.227 19814  4443 E kotlinx.coroutines.StandaloneCoroutine: Use 'coerceInputValues = true' in 'Json {}' builder to coerce nulls if property has a default value.
04-17 07:51:48.227 19814  4443 E kotlinx.coroutines.StandaloneCoroutine: JSON input: .....ame":"Channel","avatar":null,"verified":true},{"url":".....

@Bnyro Bnyro changed the title Update Subscription.kt fix: crash when importing subscriptions list with invalid avatars Apr 23, 2024
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Bnyro Bnyro merged commit 480abe1 into libre-tube:master Apr 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants