fix: click on video playlist won't load if autoplay is off #6588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
reviewed
Oct 4, 2024
| if (nextId == null && PlayingQueue.repeatMode == Player.REPEAT_MODE_ONE) { | ||
| viewModel.player.seekTo(0) | ||
| return | ||
| } | ||
|
|
||
| if (!PlayerHelper.isAutoPlayEnabled(playlistId != null)) return | ||
| if (!PlayerHelper.isAutoPlayEnabled(playlistId != null) && !isOnQueueClick) return |
There was a problem hiding this comment.
Couldn't we instead do !PlayerHelper.isAutoPlayEnabled(playlistId != null) && nextId == null, since in theory autoplay will never call this function with any video id provided (if I remember correctly how I intended to write that code) whereas the nextId is set when tapping a video in the queue?
There was a problem hiding this comment.
(same applies for your other PR, I probably merged that too quickly before thinking)
There was a problem hiding this comment.
yep, it worked in that way too, I opened another PR
|
cool. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6306