Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App strings reworked 4 #950

Merged
merged 4 commits into from
Aug 4, 2022
Merged

App strings reworked 4 #950

merged 4 commits into from
Aug 4, 2022

Conversation

comradekingu
Copy link
Contributor

List for future installments:
SponsorBlock options are a bit too long.
piped_summary" and similar aren't used?
Also,
Some options could be grayed out/removed when not active/available.

@Bnyro
Copy link
Member

Bnyro commented Aug 2, 2022

Piped summary etc is shown by long pressing the Piped card in the about section
Agreed, SponsorBlock summaries could be shorter.

<string name="auth_instance">Authentication instance</string>
<string name="auth_instance_summary">Use a different instance for authenticated calls.</string>
<string name="watch_positions_summary">Continue from last playback position</string>
<string name="auth_instance">Log in elsewhere</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should better leave that Authentication instance

Copy link
Contributor Author

@comradekingu comradekingu Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The benefit escapes me.

For reasons why this may be the official term, it is also the least friendly string.
It seems the actual meaning alludes people not already technically adept.
Albeit a setting for technical users, it is also important that regular ones understand not to use it, and more importantly aren't alarmed by its presence.

The question that arises is whether an authentication instance is needed in its own right.
This might lead people to try to input something, not knowing that there is already a sane default.
If the user doesn't know what "authenticated calls" are, in all likelihood it could be that the user thinks
that is an extra benefit available when connecting to a "different instance" to do so.

The direct translations aren't any better, and the attempted ones are more misleading.
They are also longer.

<string name="auth_instance_summary">Use a different instance for authenticated calls.</string>
<string name="watch_positions_summary">Continue from last playback position</string>
<string name="auth_instance">Log in elsewhere</string>
<string name="auth_instance_summary">Uses a different instance.</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave that too

<string name="pure_theme">Pure theme</string>
<string name="pure_theme_summary">Pure white/black theme</string>
<string name="pure_theme_summary">Only black and white</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest keeping the old term here too (Pure white/black theme)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking is that "Black and white" is a natural linguistic concept.
Moreover, it could be just "Black and white" in the title, without any summary.
This again begs the question of why it isn't a selection in the theme alternatives to begin with.
Because it isn't a black and white version of the selected theme(?)
Also both require an app restart, so no loss(?) making it one category.

On my device, the Appearance section scrolls by one entry.
Doing away with the toggle would help if not fix that completely.

<string name="update_now">Do you want to update the app now?</string>
<string name="seekbar_preview">Seekbar preview</string>
<string name="seekbar_preview_summary">Preview the video by seeking to the position when scrubbing the seekbar.</string>
<string name="update_now">Install the new LibreTube now?</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Install the new LibreTube version now?" might be better

<string name="checking_frequency">Checking frequency</string>
<string name="new_streams_count">%1$s new streams are available</string>
<string name="new_streams_by">New streams by %1$s …</string>
<string name="notify_new_streams">Livestream notifications</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has nothing to do with livestreams, it just notifies for new uploaded videos by channels the user subscribed to

<string name="checking_frequency">Checking frequency</string>
<string name="new_streams_count">%1$s new streams are available</string>
<string name="new_streams_by">New streams by %1$s …</string>
<string name="notify_new_streams">Livestream notifications</string>
Copy link
Contributor Author

@comradekingu comradekingu Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="notify_new_streams">Livestream notifications</string>
<string name="notify_new_streams">Subscription news</string>

Bnyro and others added 2 commits August 4, 2022 08:17
Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
@Bnyro Bnyro merged commit a8f3b6b into libre-tube:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants