Device does not connect succesfully to player #277
Labels
bug
Something isn't working
Comments
|
It appears that the transfer command never completes and then the devices becomes inactive. What version of the app is causing the issue? Also, which log level are you using, could you set it on |
|
I am using a Spotify App on iOS, version 8.5.86.739. Find here another screen capture which demonstrates the trace logs. In this video, you can see that the Spotify app on my MacBook does also not respond properly. |
|
I'm having the exact same issue. |
|
|
This looks a bit different from the other issue. Anyway, I should be able to have a look tomorrow. |
|
Comparison log, afterwards taking over with Linux SpotifyApp: |
devgianlu
added a commit
that referenced
this issue
Dec 21, 2020
|
@tjibbevanderlaan @paulbastian I have added some logging at the TRACE level. Could you reproduce the issue and send more logs? Please pipe the log file into a fail instead of copying it from the terminal so that the lines aren't truncated. |
|
@devgianlu thanks! I am currently not able to reproduce the issue in the exact same set-up. Will do that next Sunday. |
|
@devgianlu I can get some logs late afternoon |
|
Afternoon got pretty late ;P |
|
also my logs: |
|
Should be fixed with the latest commit, or at least it should not hang up. The problem was that it couldn't find the current track in the context and therefore threw an exception that is not logged. Now it should fallback to the first track if not found and also log any unhandled exception. @l3d00m @tjibbevanderlaan @paulbastian Please send the logs anyway so that I can get a better understanding on why it doesn't find the track. |
|
@devgianlu Thanks for the quick update, it still doesn't seem to work properly. Built from 352d6e3 |
|
@l3d00m Try with the new latest commit, I forgot to log the exception itself. |
|
Here you go |
|
@l3d00m Shoud be fixed now. There is definitely something strange with the request coming in from the app. |
|
Yes it seems to work now, thanks! :) |
|
I seem to be having the same issue on the latest commit to Dev (abde6b6). Sanitised log below: |
|
It was working for me yesterdy evning, this morning I get this error: |
|
Why the hell is Spotify sending empty URIs for tracks? The last commit should tackle the issue you observed and also log the request that is supposedly sending those empty URIs. @paulbastian @benturnberg Can you post another log at TRACE level? |
|
I will be able to continue testing on 26th |
|
Hey there,
many thanks for the quick fix. It seems to solve the problem for me - faced
it today, compiled again with the latest dev-changes and now it's working
fine again.
Am Mi., 23. Dez. 2020 um 18:40 Uhr schrieb paulbastian <
notifications@github.com>:
… I will be able to continue testing on 26th
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADGMMGSWOQOSC7HUVV5QT3SWITRDANCNFSM4U456YYA>
.
|
|
Hey @devgianlu please see below for a sanitised log (latest commit, 8f19c2f). Other details which may be relevant - up until a few days ago when I noticed it stopped working, I was using a build from a pretty old commit (had no reason to update - it was working fine for me!): c03316a. The only other significant change which I can think of on my side is a change of ISP in the last 10 days or so - this new one puts me behind a CGNAT. Cheers and happy holidays! Ben |
|
I suspect changes in the android app, this came suddenly for a lot of people at about the same time |
Perhaps both apps? I'm on iOS. |
|
It wasn't working on both my Windows- & Android-client too this evening, before testing the fix. |
devgianlu
added a commit
that referenced
this issue
Dec 24, 2020
|
It looks like Spotify stopped using track URIs: The main problem here is that there is not a direct correlation between URIs and GIDs because the URI could be After experiencing this myself, I think I solved it for everyone. If I get some approvals, I'll push a new update. Happy holidays! |
|
Hey that's good news. Is there another update required or have the changes
from yesterday solved the issue?
devgianlu <notifications@github.com> schrieb am Do., 24. Dez. 2020, 14:55:
… It looks like Spotify stopped using track URIs:
tracks {
uri: ""
uid: "222f3dac11464c6d2db8"
gid: "\315<\351\364e\242N\262\241\212\226\312\233\241\3327"
}
tracks {
uri: ""
uid: "80705cdba89a6cba03c1"
gid: "\313\362\021M\262\247Ja\237\256\254\257N\t\336\217"
}
tracks {
uri: ""
uid: "75c777594415b5ce7307"
gid: "\016\'\202\321p\324H\235\264Z\204\262\036O\325\272"
}
The main problem here is that there is not a direct correlation between
URIs and GIDs because the URI could be spotify:track: or spotify:episode:.
After experiencing this myself, I think I solved it for everyone. If I get
some approvals, I'll push a new update.
Happy holidays!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADGMMEY4YJL6JKYD5QWGALSWNB5LANCNFSM4U456YYA>
.
|
|
@funtax It wasn't solved on my side, others said it was fixed. |
|
I hope there is a fix today, so I can celebrate with good music.
El jue, 24 dic 2020 a las 11:11, devgianlu (<notifications@github.com>)
escribió:
… @funtax <https://github.com/funtax> It wasn't solved on my side, others
said it was fixed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBWF77PVT5P4VHIRLRRWATSWNDZJANCNFSM4U456YYA>
.
|
|
@elganzua124 If you are using @spocon then there is no hope to get the update today or even tomorrow because of the package repository. The only solution is to compile the latest commit which already has the fix. |
|
@devgianlu yup, I'm using @spocon. I just compiled |
|
Looks good to me @devgianlu - happy holidays and thank you 👍 |
Actually, it's not working again :( (I'd been out, and I came home)... |
|
I did something that I tried to avoid: infer the URI from the context URI. The logic is fairly simple, but not "Spotify-proof", since they may change which contexts contain tracks or episode. @benturnberg Should definitely work now. |
Thanks @devgianlu - recompiled and first attempt works. Will keep testing and come back to you with the result. |
|
seems stable to me the last days |
|
Same, the new build works flawlessly so far for me |
|
I'm using the latest build since yesterday and was not able to reproduce the issue so far. Perfect! |
|
Release 1.5.3 is out: https://github.com/librespot-org/librespot-java/releases/tag/v1.5.3 Thanks to everybody on this thread! |
|
I'm still having occasional problems - not sure if related. Will start a new issue with logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I am not able to connect to the Player with my mobile device. However -- this worked before, so I am not sure why it does not work anymore. This is not the case for every device. I have another mobile phone available which connects instantly to the service.
To Reproduce
I am not able to find the exact procedure to get in this particular state. Rebooting the Player service, or restarting the Spotify app on my mobile phone does not have any impact.
Expected behavior
I expected to see no significant differences when connecting one device or another to the player.
Version/Commit
Ubuntu 20.04.1 LTS (GNU/Linux 5.4.0-58-generic x86_64)
Openjdk version "14.0.2" 2020-07-14
Compiled locally, based on one of the latest commits on
dev, f69d3ed.Screenshots/Stracktraces/Logs
I recorded a screen capture to show the logs while the mobile device trying to connect. The 🦄 device fails to connect. This is the device as shown in the video. The device 'femkevonp' connects instantly. This device is not part of the screen capture.
https://drive.google.com/file/d/1btJTWGZLfNz_FNGTNNQ2PZ1QaJEQ-F3j/view?usp=sharing
Please find the logs at the end of this issue. Thanks for helping out!
The text was updated successfully, but these errors were encountered: